dsentker's avatar

Daniel Sentker

dsentker

Member since

95

Total Reputation

5

Total Arguments

9

Total Votes for Arguments

Arguments and votes

1

not logical to remove them.

Share:
Read the RFC: new MyClass()->method() without parentheses dsentker avatar
dsentker
voted no
4

I don't think removing parenthese is a good idea

Share:
Read the RFC: new MyClass()->method() without parentheses iyogesharma avatar
iyogesharma
voted no
1

Even though this is a nice syntax that we also know from other programming languages, I think it is problematic. The reason for this lies in the ambiguity: How does the developer know whether $entity->setSlug() = '...' does something different than $entity->slug?

Without property hooks the case is quite clear: the setter method could still contain some "under-the-hood" steps (such as validation), while directly changing the property sets the value "unfiltered". It should stay that way.

Share:
Read the RFC: Property Hooks dsentker avatar
dsentker
voted no
20

While I'm not against the concept in general, this implementation is not well-done. The $value variables comes from nowhere and makes it confusing - it looks like an undefined variable and a quick glance at it, was the first thing I thought - where is $value coming from? Why not just use $name within that block? Same with $field? Why not just return the value that is going to be set? This is one of the more confusing RFCs I've seen and does not follow the PHP-code style, makes things confusing for both new and experienced coders. In it's current format, I can't approve with good conscience.

Share:
Read the RFC: Property Hooks jim avatar
jim
voted no
1

There is absolutely no need to mix interfaces with abstract classes. interfaces/contracts should not include any concrete implementation.

Share:
Read the RFC: Interface Default Methods dsentker avatar
dsentker
voted no
1

Another (extended) syntax for anonymous functions. We do not need to apply closures on everything.

Share:
Read the RFC: Short Closures 2.0 dsentker avatar
dsentker
voted no
1

No benefit, it is also feels bad to use a function name as string when referencing it. Limited usefulness if the via-string-called-function has more than one argument.

Share:
Read the RFC: The Pipe Operator dsentker avatar
dsentker
voted no
18

It's almost as messy as putting all the functions into each other.

Share:
Read the RFC: The Pipe Operator t avatar
t
voted no
44

It looks pretty much the exact function as abstract class. I still think interfaces/contracts should not include any concrete implementation

Share:
Read the RFC: Interface Default Methods nabeel avatar
nabeel
voted no
RSS Feed Contribute Watch on YouTube Our License
© 2024 RFC Vote. This project is open source. Contribute and collaborate with us!