Property Hooks

Developers often use methods to wrap and guard access to object properties. There are several highly common patterns for such logic, which in practice may be verbose to implement repeatedly. Alternatively, developers may use __get and __set to intercept reads and writes generically, but that is a sledge-hammer approach that intercepts all undefined (and some defined) properties unconditionally. Property hooks provide a more targeted, purpose-built tool for common property interactions.

class User 
{
    public string $name {
        set {
            if (strlen($value) === 0) {
                throw new ValueError("Name must be non-empty");
            }
            $this->name = $value;
        }
    }
 
    public function __construct(string $name) {
        $this->name = $name;
    }
}

You can play around with them on 3v4l.org

Click the bar to cast your vote!
61%
39%
1

Late to the game here after it is all but guaranteed to pass, but I see this as a plus because it provides badly needed structure instead of magic __get() and __set() variables.

Share:
mikeschinkel avatar
mikeschinkel
voted yes
1

Looks like a good idea. first, I thought it will be too complicated for PHP to have this kind of syntax, but I've changed my mind, I think it will be amazing to have it in the language

Share:
Contributor serhii avatar
serhii
voted yes
1

use of the Value-Object seems better. "set" within a block of string doesn't look clean IMO.

Share:
junveloper avatar
junveloper
voted no
1

like it

Share:
parijke avatar
parijke
voted yes
1

Though I'd prefer only allowing the syntax with parentheses like set($value)

Share:
micheljonkman avatar
micheljonkman
voted yes
1

I like it

Share:
indigoram89 avatar
indigoram89
voted yes
1

Makes it more readable.

Share:
eugen avatar
eugen
voted yes
1

I do believe this has merit and uses cases, but I agree that value objects would cover this better and there are other things the developers could put their time towards

Share:
nathan avatar
nathan
voted no
1

This RFC needs a re-work. While I support the idea, I don't think this is the right approach. The fact that the RFC is so long is a massive red flag. For example there are 4 different ways to define hooks:

class User
{
    public string $username {
        set(string $value) {
            $this->username = strtolower($value);
        }
    }
}
class User
{
    public string $username {
        set(string $value) {
            $field = strtolower($value);
        }
    }
}
class User
{
    public string $username {
        set => strtolower($value);
    }
}
class User
{
    public function __construct(
        public string $username { set => strtolower($value); }
    ) {}
}

Why?!

This is not what PHP needs.

Share:
moebrowne avatar
moebrowne
voted no
1

I enjoy using set/get hooks in C# and strongly believe they are truly useful. Also, having them in interfaces is excellent!

Share:
baldie avatar
baldie
voted yes
1

Even if you won't use this yourselve, it will allow libraries and frameworks to do some really cool stuff. LGTM!

Share:
sandermuller avatar
sandermuller
voted yes
1

I've always envied C# developers for this feature in C#, I've been using __get() and __set() methods to achieve it

Share:
hsemix avatar
hsemix
voted yes
1

It's hard to read.

Share:
bYemma avatar
bYemma
voted no
1

This RFC does not solve any issue, that cannot be solved right now with almost the same code, and makes the code harder to read. Beside this, this syntax invites developers to mix concerns.

Share:
im-a-teapot avatar
im-a-teapot
voted no
1

Getters and setters are more and more considered bad : https://www.infoworld.com/article/2073723/why-getter-and-setter-methods-are-evil.html

This features feels like a C# fix applied on PHP which I don't like. We should focus on designing better classes, not fix a bad pattern.

Share:
trehinos avatar
trehinos
voted no

Check out another RFCs

Short Closures 2.0

This RFC proposes a way to have multi-line short closures — closures that don't need explicit use statements, but can still have multiple lines and a return statement.

101
373 yes
66 no
Interface Default Methods

Interface Default Methods improves backwards compatibility when changing interfaces, but also add a way to have multi-inheritance in PHP.

95
168 yes
264 no
new MyClass()->method() without parentheses

Chain method on newly created objects without parentheses

54
95 yes
16 no
RSS Feed Contribute Watch on YouTube Our License
© 2024 RFC Vote. This project is open source. Contribute and collaborate with us!